fix(RotateTool.js): evaluation of initialRotation #1461
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: RotateTool rotate too quick when viewport.initialRotation is 0
Codecov Report
@@ Coverage Diff @@
## master #1461 +/- ##
=======================================
Coverage 20.16% 20.16%
=======================================
Files 287 287
Lines 10102 10102
Branches 2060 2060
=======================================
Hits 2037 2037
Misses 6852 6852
Partials 1213 1213
Continue to review full report at Codecov.
|
|
Hi ! Checking for const initialRotation = viewport.initialRotation !== undefined
? viewport.initialRotation
: viewport.rotation;Hope it helps 🙏 For those needing the fix urgently, you can use a custom strategy with the RotateTool. |
|
@LaurentTrk Thx, I just made a new commit including the condition of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: RotateTool rotate too quick when viewport.initialRotation is 0
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
RotateTool rotate too quick when viewport.initialRotation is 0
What is the new behavior (if this is a feature change)?
rotate normally
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: